Skip to content

Fix/GitHub issues batch#630

Merged
aunali8812 merged 2 commits into
stagingfrom
fix/github-issues-batch
May 21, 2026
Merged

Fix/GitHub issues batch#630
aunali8812 merged 2 commits into
stagingfrom
fix/github-issues-batch

Conversation

@aunali8812

@aunali8812 aunali8812 commented May 21, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features

    • Rich text editor now supports Mod-k keyboard shortcut for quick link management with a prompt dialog to add, edit, or remove links.

  • Bug Fixes

    • Campaign editor automatically adjusts outdated start dates to valid times while editing to prevent scheduling errors.

Review Change Stack

@aunali8812 aunali8812 requested a review from Ebube111 as a code owner May 21, 2026 17:54
@vercel

vercel Bot commented May 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
potlock-next-app Ready Ready Preview, Comment May 21, 2026 5:54pm

Request Review

@aunali8812 aunali8812 merged commit a8ad4f9 into staging May 21, 2026
3 of 4 checks passed
@coderabbitai

coderabbitai Bot commented May 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 44723ceb-9ddc-4c0f-b094-b337bbbecaf5

📥 Commits

Reviewing files that changed from the base of the PR and between 64d13b4 and 6318c29.

📒 Files selected for processing (2)
  • src/common/ui/form/components/richtext.tsx
  • src/entities/campaign/components/editor.tsx

Walkthrough

This PR adds a keyboard shortcut for link insertion in the RichText editor and improves campaign form datetime handling by automatically correcting start times that drift into the past during form editing.

Changes

RichText Link Keyboard Shortcut

Layer / File(s) Summary
Link insertion via Mod-k shortcut
src/common/ui/form/components/richtext.tsx		 TipTap link extension configured with Mod-k keyboard shortcut that prompts for URL with the current link's href as default. Cancelling does nothing, entering empty string unsets the link mark, and entering a URL sets or updates the link mark.

Campaign Min-Start Datetime Drift Correction

Layer / File(s) Summary
Min-start updater with drift correction and form re-subscription
src/entities/campaign/components/editor.tsx		 The minimum start datetime updater now computes the minimum instant once and silently bumps the stored start_ms forward to that minimum if the current value has drifted into the past. The useEffect dependency list changes from empty to [form], causing the updater interval to re-establish when the form reference changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • Ebube111

Poem

🐰 A shortcut springs forth—Mod-k for links so swift,
While time keeps its promise, no backward drift,
The form stays fresh, the editor keen,
Simplicity in keystrokes, grace in the scene! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/github-issues-batch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot mentioned this pull request May 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ebube111 Ebube111 Awaiting requested review from Ebube111 Ebube111 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aunali8812